-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make refresh commands runnable inside container for ddev #205
Conversation
because that's all we have.
@mmatsoo / @mattdaniel Wondering if either of you have the bandwidth to look at this Usher change, allowing refresh to happen within the container instead of having to run it in the host OS context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I left one comment for contemplation, but looks good.
I am going to add this to devops agenda or tech back end meeting of some sort so I can broadcast the implications of this change. |
@mattdaniel I'd love your eyeballs on this at some point. |
Run a comparison on an in-container database load versus using ddev import-db for a site like JFK. @mattdaniel Makes the point that implementing this does not remove the possibility of using the ddev native database import. @agarzola It is important to engineer our tooling so that it can be more agnostic, more composable. So the less we build in assumptions about |
Going to hold off on merging this until the next devops council so we can broadcast the change and any potential fallout. Also not good to release this during time I am out of office. |
We need a rollout plan for this to minimize disruptions.
#! /bin/bash
## Description: Runs robo inside ddev
## Usage: robo
## Example: "ddev robo deploy:drupal"
./vendor/bin/robo $@ |
As described in #204, we can't run robo refresh divorced from the host OS when using ddev because unfortunately the ddev-specific implementations are using ddev commands, which cannot be run inside the container.
Removing the reliance on those commands and using native drupal/drush instead, allows us to run the robo refresh sequence entirely within the service container, meaning the developer doesn't have to futz with php versions, composer etc, on the host OS.
Resolves #204