Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container-pull): add support for multi arch #290

Merged
merged 3 commits into from
May 17, 2024
Merged

feat(container-pull): add support for multi arch #290

merged 3 commits into from
May 17, 2024

Conversation

carlosmmatos
Copy link
Contributor

Multi-Architecture Support Enhancements

  • Multi-architecture support has been added to the Falcon Container Sensor Pull script, enabling compatibility with mixed platform k8s clusters or environments.
  • The script now supports the following enhancements:
    • Copying a multi-arch image from CrowdStrike to another registry
    • Copying a specific architecture from a multi-arch image from CrowdStrike to another registry
    • Pulling a specific architecture from a multi-arch image locally
    • --list-tags now supports displaying multi-arch images, whether you specify a platform or not.

Documentation Updates

  • The README has been updated to reflect the deprecated features, upcoming changes, and multi-architecture support enhancements.
  • Detailed usage examples and security recommendations have been added to facilitate user understanding and adoption.
  • Instructions for copying multi-arch images and pulling images for specific platforms have been included, along with recommendations for using Skopeo.

@carlosmmatos
feat(container-pull): add logic for multi-arch support
4c5e87a 
TBD: figure out how to handle platform + multi-arch
@carlosmmatos
fix(container-pull): add logic for listing tags with multi-arch
b9c3798 
Ensure we capture multi-arch images even when a platform is specified.
This will ensure a user can pull a platform from a multi-arch image,
since this is a valid use case. Also fixes a few minor issues.
@carlosmmatos
docs(container-pull): update readme for multi-arch support changes
843b3ff
@carlosmmatos carlosmmatos added enhancement New feature or request bash container linux next release Issues targeted for next release labels May 14, 2024
@carlosmmatos carlosmmatos self-assigned this May 14, 2024
@carlosmmatos carlosmmatos added this to the v1.4.0 milestone May 14, 2024
@carlosmmatos carlosmmatos linked an issue May 14, 2024 that may be closed by this pull request
container-pull script: identify appropriate way to support multi-arch registry copy #289
Closed
@carlosmmatos carlosmmatos merged commit 9fd4931 into CrowdStrike:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redhatrises redhatrises redhatrises approved these changes

@CS-kyleweishaar CS-kyleweishaar Awaiting requested review from CS-kyleweishaar

Assignees

@carlosmmatos carlosmmatos

Labels
bash container enhancement New feature or request linux next release Issues targeted for next release
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

container-pull script: identify appropriate way to support multi-arch registry copy
2 participants
@carlosmmatos @redhatrises