Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallel scan extension for CPU #17

Merged
merged 15 commits into from
Jan 24, 2025
Merged

feat: parallel scan extension for CPU #17

merged 15 commits into from
Jan 24, 2025

Conversation

yoyolicoris
Copy link
Member

Accelerate first-order filter on CPU for small batch sizes.
This PR serves as a first step to gradually remove numba code and use the native cpp bindings by PyTorch. #10 could be merged after this PR.
The empirical benchmark shows the extension is faster when batch size < 2.

I plan to keep the main for development purposes, so the version will always be *.dev. I will make a separate branch for the stable version.

@yoyolicoris
Copy link
Member Author

A separate function like first_order_recurrence(x, a, zi) might be clearer to users about this update.

@christhetree
Copy link
Member

I left some comments, otherwise LGTM. Also I don't think I understand what Recurrence is doing but TBF I didn't dig deeper into that part of the code.

@yoyolicoris yoyolicoris merged commit 5801748 into main Jan 24, 2025
5 checks passed
@yoyolicoris yoyolicoris deleted the feat-cpp-scan branch January 24, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants