Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docraptor.yaml #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update docraptor.yaml #3

wants to merge 1 commit into from

Conversation

janxious
Copy link
Contributor

document_content as a singular required field vs. one of either content or url is not longer okay as of swagger 2.2. This has to be removed because validations are being added to the gen'ed code that would prevent using urls to make docs

`document_content` as a singular required field vs. one of either content or url is not longer okay as of swagger 2.2. This has to be removed because validations are being added to the gen'ed code that would prevent using urls to make docs
@mediocretes
Copy link
Contributor

I'm guessing there's no mechanism for enforcing one-or-the-other?

Seems like implementing something on the API side that is "your_document_here" and people put whatever in there is the move, if we want to be strict and correct.

@mediocretes
Copy link
Contributor

(:+1:)

@janxious
Copy link
Contributor Author

janxious commented Aug 15, 2016

I'm guessing there's no mechanism for enforcing one-or-the-other?
Correct.

Seems like implementing something on the API side that is "your_document_here" and people put whatever in there is the move, if we want to be strict and correct.

Yeah, that is the most likely resolution. @jqr and I were discussing it in an issue on DR proper.

@jqr
Copy link
Contributor

jqr commented Oct 18, 2016

I suspect a similar fix will make it into the next branch for the 2.0 clients, leaving this open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants