Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 1: DOM text reinterpreted as HTML #21

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

puria
Copy link
Member

@puria puria commented Dec 13, 2024

Fixes https://github.com/ForkbombEu/pqspread/security/code-scanning/1

To fix the problem, we need to ensure that any text content retrieved from the DOM and inserted into the HTML is properly escaped to prevent XSS attacks. The best way to fix this issue is to use a function that escapes HTML special characters before inserting the content into the HTML template.

We will:

  1. Create a utility function to escape HTML special characters.
  2. Use this function to escape the title, content, and description attributes before inserting them into the HTML template.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant