Torus envelope fix (partially) #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcatalanUNED
pushed a commit
that referenced
this pull request
Dec 12, 2024
* adding version 1.3.0 to docs (#274) * Update version_switcher.json Adding the new version to the documentation. * correction sphere additional plane * Adding the mention of libmamba solver to installation instructions (#280) * optimal bounbox to fix Torus bug * optimal bounbox to fix Torus bug * Torus envelope fix (partially) (#286) * Update of the documentation layout (#285) * update_of_docs * test * update 2 * update 3 * update 4 * test 5 * update 6 * update 7 * update 8 * test materials * test again * final --------- Co-authored-by: Jonathan Shimwell <mail@jshimwell.com> Co-authored-by: Patrick Sauvan <psauvan@ind.uned.es> Co-authored-by: Aljaz Kolsek (F4E) <158494312+akolsek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add modifications to solve partially some problems with contigous toroidal face forming a closed surface.
In order to fully solve the problem, original solid must be divide in smallest parts.