Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds return statement to points_to_coeffs #294

Merged

Conversation

agrieve-cfs
Copy link

@agrieve-cfs agrieve-cfs commented Dec 17, 2024

Description

Adds a return statement to coeffs_to_points function in MCNPInput.py

Fixes Issue

#292

Checklist

  • I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
  • I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code
  • [N/A] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works

@shimwell
Copy link
Collaborator

shimwell commented Dec 17, 2024

Thanks for making this PR and clear issue #292

It looks useul and has also been proposed by others. So I think we should merge this one in as it is good to go.

This change has also been suggested in #291 . But just like #293 it was based of the wrong branch.

LGTM

@agrieve-cfs
Copy link
Author

Thanks for making this PR and clear issue

It looks useul and has also been proposed by others. So I think we should merge this one in as it is good to go.

This change has also been suggested in #291 . But just like #293 it was based of the wrong branch.

LGTM

@shimwell
Admitedly, I did not look at the current PRs or Issues.
It does look like @py1sl's PR is more inclusive and adds documentation (though neither of us have added a test for this particular feature). Perhaps @py1sl can rebase to dev, dropping main commits and force push to his PR? I don't want to rush something into the repo (especially since I have a working version locally haha).

@akolsek
Copy link
Member

akolsek commented Dec 19, 2024

Whenever you can @psauvan , please review this PR.

@akolsek akolsek mentioned this pull request Dec 19, 2024
4 tasks
@psauvan psauvan merged commit e5581d7 into GEOUNED-org:dev Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants