Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/notify reward audit fix #48

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix/notify reward audit fix #48

wants to merge 5 commits into from

Conversation

aminlatifi
Copy link
Member

divine-comedian
divine-comedian requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@divine-comedian divine-comedian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a couple typos and just need clarification on the new requirement check

contracts/GardenUnipoolTokenDistributor.sol Outdated Show resolved Hide resolved
contracts/UnipoolTokenDistributor.sol Outdated
require(success, 'UnipoolTokenDistributor: CALL_FAILED');
(uint256 allocatedTokens,) = abi.decode(data, (uint256, uint256));

require(allocatedTokens >= _reward, 'UnipoolTokenDistributor: NOT_ENOUGH_TOKEND_ISTRO_BALANCE');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another typo here

contracts/UnipoolTokenDistributor.sol Show resolved Hide resolved
@laurenluz
Copy link
Member

@aminlatifi can you finish this one out?

@divine-comedian
Copy link
Contributor

@aminlatifi approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divine-comedian divine-comedian divine-comedian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix minor issue on notify reward on uinpools
3 participants
@aminlatifi @laurenluz @divine-comedian