-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an AWS sync backend #492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmitche
force-pushed
the
issue368
branch
3 times, most recently
from
December 1, 2024 14:53
c630213
to
ddec215
Compare
Closed
djmitche
force-pushed
the
issue368
branch
2 times, most recently
from
December 1, 2024 23:12
74dc215
to
bc65f9e
Compare
Closed
@djmitche p sure you meant to tag someone else |
Sorry -- @travisby! |
ryneeverett
approved these changes
Dec 3, 2024
This approach is very similar to that of GCP, and utilizes a similar conditional-write mechanism to prevent conflicting updates to the `latest` key. This updates the package major version to 1.0.0, as it modifies the `ServerConfig` enum by adding a new variant -- a semver-breaking change. To avoid further major version bumps from additional variants, this also adds `#[non-exhaustive]` to the enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach is very similar to that of GCP, and utilizes a similar conditional-write mechanism to prevent conflicting updates to the
latest
key.This updates the package major version to 1.0.0, as it modifies the
ServerConfig
enum by adding a new variant -- a semver-breaking change. To avoid further major version bumps from additional variants, this also adds#[non-exhaustive]
to the enum.This also bumps the MSRV to the MSRV of the AWS SDK (1.78.0).