Refactor Expire Tasks #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I PR'ed the wrong clone... 🤦 |
djmitche
reviewed
Jan 6, 2025
| .drain() | ||
| .filter(|(_, t)| t.get_status() == Status::Deleted) |
There was a problem hiding this comment.
Oh no -- this line should not have been removed! We're now expiring all old tasks, whether deleted or not!
djmitche
added a commit
to djmitche/taskchampion
that referenced
this pull request
Jan 6, 2025
In GothenburgBitFactory#510, a bug was introduced where _any_ old tsaks would be purged, not just deleted tasks.
djmitche
added a commit
to djmitche/taskchampion
that referenced
this pull request
Jan 6, 2025
In GothenburgBitFactory#510, a bug was introduced where _any_ old tasks would be purged, not just deleted tasks.
djmitche
added a commit
that referenced
this pull request
Jan 6, 2025
* Only expire deleted tasks. In #510, a bug was introduced where _any_ old tasks would be purged, not just deleted tasks. * avoid repeating the string 'deleted'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a small patch to address #436. This is my first PR so I'm not sure if I did it correctly, but it seems to pass all of the tests?