Lab. 1, Lab. 2 _and_ Lab. 3 is done.
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Eugeny Sergeevich. I have merged your fixes. |
|
Hello again. I have did |
Egorkin-enabled
changed the title
Lab. 1 _and_ Lab. 2 done.Lab. 1, Lab. 2 _and_ Lab. 3 is done.
jskonst
requested changes
Oct 5, 2024
.gitignore
Outdated
| @@ -0,0 +1,130 @@ | |||
| # Logs | |||
package-lock.json
Outdated
There was a problem hiding this comment.
его и node_modules рядом надо удалить
package.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
rpgsaga/saga/.gitignore
Outdated
| @@ -0,0 +1,130 @@ | |||
| # Logs | |||
There was a problem hiding this comment.
в каталоге выше был gitignore
rpgsaga/saga/src/lab1/funcs.ts
Outdated
| const arr = new Array<number>(itemCount); | ||
| let xCurrent = xStart; | ||
| let index = 0; | ||
| while (xCurrent < xEnd) { |
rpgsaga/saga/src/lab1/funcs.ts
Outdated
|
|
||
| export function calculatePoints(a: number, b: number, xes: Array<number>): Array<number> { | ||
| const results: Array<number> = new Array<number>(xes.length); | ||
| for (const index in xes) { |
There was a problem hiding this comment.
Suggested change
| for (const index in xes) { | |
| for (const index of xes) { |
| import * as pointEngine from '../../src/lab1/funcs'; | ||
|
|
||
| // Let test our task. | ||
| it('should be empty if end >= start.', () => { |
|
Hello, Eugeny Sergeevich. I've applied all of the remarks. I hope it's all right. |
jskonst
reviewed
Dec 7, 2024
| private _birthDate: Date; | ||
|
|
||
| constructor(name: string, birthdate: Date, color: string) { | ||
| this._name = name; |
There was a problem hiding this comment.
Suggested change
| this._name = name; | |
| this.name = name; |
jskonst
reviewed
Dec 7, 2024
|
|
||
| constructor(name: string, birthdate: Date, color: string) { | ||
| this._name = name; | ||
| this._birthDate = birthdate; |
There was a problem hiding this comment.
Suggested change
| this._birthDate = birthdate; | |
| this.birthDate = birthdate; |
jskonst
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Eugeny Sergeevich. I'm Kozlov Egor, student of 2/278 group.
I want to say that I have written all CodeWars tasks. Also made TS laboratory with Unit tests.
At CodeWars I've used different languages:
Is everything did OK? I'm waiting for a feedback. Thank you and have a nice day!