codewars+mathFunc+Classes #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Укажи правильный base. Если у тебя нет ветки, отпишись, создадим |
FeLL1kS
reviewed
Oct 10, 2024
| this._color = color; | ||
| } | ||
|
|
||
| setAge(age: number){ |
There was a problem hiding this comment.
Геттеры и сеттеры пишутся по-другому, пожалуйста переделай корректно:
https://learn.javascript.ru/property-accessors?ysclid=m2342z978m930232161
| it('Должно выкинуть ошибку при установке отрицательного возраста кролика', () => { | ||
| const testRabbit2 = new Rabbit(2, 'ewrt', 'grey'); | ||
|
|
||
| expect(() => testRabbit2.setAge(-2)).toThrow('age cant be below zero'); |
There was a problem hiding this comment.
Можно еще проверять на тип ошибки, просто для информации, можешь это не делать:
expect(new Rabbit(2, 'ewrt', 'grey').rejects.toBeInstanceOf(Error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.