add: add option to format the star text in the list #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, thank you for the pull request. The main repository for this plugin is actually located here: https://github.com/Jannyboy11/F2P-Star-Assist. Even though usually I am open to new features, I cannot really see what a configurable starinfo format accomplishes. The 'T' and 'W' are also still hardcoded, so it's not even truly configurable. In order for me to accept this PR, I would like the T and W to be user-configurable as well (so, part of the format string). |
Jannyboy11
reviewed
Oct 29, 2023
| section = MISCELLANEOUS | ||
| ) | ||
| default String callOutFormat() { | ||
| return "{world} {tier} {location}"; |
There was a problem hiding this comment.
Should be "W{world} T{tier} {location}" then, right?
Jannyboy11
reviewed
Oct 29, 2023
| final String text = "T" + star.getTier().getSize() + " W" + star.getWorld() + " " + star.getLocation(); | ||
| final String text = this.config.callOutFormat | ||
|
|
||
| if(text.contains("{world}") && text.contains("{tier}") && text.contains("{location}")){ // if provided format is valid |
There was a problem hiding this comment.
In this codebase I use spaces before and after keywords, so this should be if ( at the beginning of the line, and at the end of the line ) {.
Jannyboy11
reviewed
Oct 29, 2023
| text.replace("{world}", star.getWorld()); | ||
| text.replace("{tier}", "T"+star.getTier().getSize()); | ||
| text.replace("{location}", star.getLocation()); | ||
| }else{ // otherwise default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added an option to format the text in the star list
with tags {world} {tier} {location}
so you can swap their places or have any custom formatting