Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: event-hub 모듈 health-check-api 추가 #177

Merged
merged 1 commit into from
Jan 24, 2025
Merged

feat: event-hub 모듈 health-check-api 추가 #177

merged 1 commit into from
Jan 24, 2025

Conversation

Suxxxxhyun
Copy link
Collaborator

🔧 어떤 작업인가요?

event-hub 모듈 내 health-check-api를 추가하였습니다.

#️⃣ 연관된 이슈

#176

💡 리뷰어에게 하고 싶은 말

  • 어제 말씀드린대로, ALB가 여러 서버들에게 요청을 보낼때 특정 서버가 살았는지 죽었는지를 확인하기 위한 API가 필요하여 이를 위한 기능을 추가하였습니다.

🙏 아래 내용이 모두 충족 되었는지 확인해주세요 🙏

  • PR 이전 dev 브랜치 병합 하셨나요?
  • PR 이전 빌드 테스트 정상적으로 성공했나요?
  • PR 상세내용이 충분히 기재 되었나요?
  • PR 리뷰어, 할당자, 라벨, 프로젝트 확인

@Suxxxxhyun Suxxxxhyun added ✨ Feat 새로운 기능 추가 priority 우선순위 labels Jan 24, 2025
@Suxxxxhyun Suxxxxhyun requested a review from tomatozil January 24, 2025 00:43
@Suxxxxhyun Suxxxxhyun self-assigned this Jan 24, 2025
tomatozil
tomatozil approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@tomatozil tomatozil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구두로 설명 들었던 부분이군요!
alb가 사용할 api를 추가 확인했습니다 ~

@Suxxxxhyun Suxxxxhyun merged commit bc5a63f into develop Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomatozil tomatozil tomatozil approved these changes

Assignees

@Suxxxxhyun Suxxxxhyun

Labels
✨ Feat 새로운 기능 추가 priority 우선순위
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suxxxxhyun @tomatozil