[FIX] Fix newline after program with exit code 130 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itislu
force-pushed
the
fix-issue-257
branch
from
ec9b0f3 to
176c335
Compare
LeaYeh
force-pushed
the
fix-issue-257
branch
from
176c335 to
b2890be
Compare
|
Something is wrong with the CI shell scripts...
|
Bash also seems to put it to stderr. Tested with: Terminal 1 (stdout): `tty` -> `/dev/pts/*` Terminal 2 (stderr): `bash >/dev/pts/*`
`./return_130 || echo 123` did not print `123`.
It could happen bc of a certain order of including headers that `_DEFAULT_SOURCE` was redefined.
itislu
force-pushed
the
fix-issue-257
branch
from
b2890be to
f7e72c1
Compare
itislu
force-pushed
the
fix-issue-257
branch
from
866019e to
11aa0a2
Compare
LeaYeh
approved these changes
Nov 16, 2024
LeaYeh
requested changes
Nov 16, 2024
|
And I feel sometimes you over norminattee make the code confusing me. |
|
I'm happy to do a code review on campus whenever you have time! |
LeaYeh
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes programs with exit code 130 causing a newline.
Fixes minishell running in minishell printing too many newlines after SIGINT + exit.
Fixes nested subshells printing too many newlines:
( ( (cat) ) )Fixes
cat | ./segfaultbehavior:Segmentation faultonly gets printed at end of pipeline.This also fixes the exit code affecting
&&/||:./return_130 || echo 123did not print123.Resolves [BUG] minishell running in minishell prints too many newlines after exiting, also in subshells #257
Known issues
(sleep 3 && ./segfault)should not printSegmentation fault(which is super weird bc(./segfault)does printSegmentation fault!