Skip to content

Commit

Permalink
Pass stdin to the bootstrap container. (#86)
Browse files Browse the repository at this point in the history
Detect TTY before assigning stdin

Set a default value for LOCALHOST

Expose port and use 0.0.0.0 for localhost

[Feature] Add the new version v1.0.5  LRN-45173

Co-authored-by: david-scarratt-lrn <david.scarratt@learnosity.com>
  • Loading branch information
sreenivasa-murty-lrn and david-scarratt-lrn authored Oct 14, 2024
1 parent 518a2d3 commit a224225
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.0.4
v1.0.5
5 changes: 5 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ and this project adheres to [Semantic
Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [v1.0.5] - 2024-10-14
### Refactor
- Fixed the signature mismatch issue.
- Fixed the issue while running the 'make quickstart'

### Fixed
- Fixed an inconsistency with encoding to JSON
- Fixed incorrect replacement of SERVICE_ITEMS_API by SERVICE_EVENTS_API
Expand Down
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ DEBIAN_VERSION = $(or $(DEBIAN_VERSION-$(PHP_VERSION)),$(DEBIAN_VERSION-def))
COMPOSER_VERSION-7.1 = 2.2
COMPOSER_VERSION-def = 2.7.6
COMPOSER_VERSION = $(or $(COMPOSER_VERSION-$(PHP_VERSION)),$(COMPOSER_VERSION-def))
LOCALHOST = 0.0.0.0

IMAGE = php-cli-composer:$(PHP_VERSION)-$(DEBIAN_VERSION)-$(COMPOSER_VERSION)

Expand All @@ -27,13 +28,15 @@ TARGETS = all build devbuild prodbuild \
.default: all

ifneq (,$(DOCKER))
TTYFLAGS := $(shell if [ -t 0 ] ; then echo "-it"; else echo "-t"; fi)
# Re-run the make command in a container
DKR = docker container run -t --rm \
DKR = docker container run $(TTYFLAGS) --rm \
-v $(CURDIR):/srv/sdk/php:z,delegated \
-v lrn-sdk-php_cache:/root/.composer \
-w /srv/sdk/php \
-e LRN_SDK_NO_DOCKER=1 \
-e ENV -e REGION -e VER \
-p 8000:8000 \
$(if $(findstring dev,$(ENV)),--net host) \
$(IMAGE)

Expand Down

0 comments on commit a224225

Please sign in to comment.