Merge pull request #72 from Learnosity/LRN-43018/BUG/fix-service-name

[BUG] Rename author-aide to authoraide
Learnosity · Apr 2, 2024 · d26e587 · d26e587
2 parents 820f0ab + 6a4ae10
commit d26e587
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic
 Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+## [v1.0.3] - 2024-04-07
+### Added
+- Rename author-aide to authoraide
+
 
 ## [v1.0.3] - 2024-03-07
 ### Added

diff --git a/src/Request/Init.php b/src/Request/Init.php
@@ -39,7 +39,7 @@ class Init
      * Valid values (see also `$validServices`):
      *  - assess
      *  - author
-     *  - author-aide
+     *  - authoraide
      *  - data
      *  - events
      *  - items
@@ -110,7 +110,7 @@ class Init
      * Service names that are valid for `$service`
      * @var array
      */
-    private $validServices = ['assess', 'author', 'author-aide', 'data', 'events', 'items', 'questions', 'reports'];
+    private $validServices = ['assess', 'author', 'authoraide', 'data', 'events', 'items', 'questions', 'reports'];
 
     /**
      * @var SignatureFactory
@@ -247,7 +247,7 @@ public function generate(bool $encode = true)
                     $this->requestPacket;
                 break;
             case 'author':
-            case 'author-aide':
+            case 'authoraide':
             case 'items':
             case 'reports':
                 // Add the security packet (with signature) to the output

diff --git a/tests/Request/InitTest.php b/tests/Request/InitTest.php
@@ -362,7 +362,7 @@ public static function getWorkingAuthorApiParams(bool $assoc = false): array
      */
     public static function getWorkingAuthorAideApiParams(bool $assoc = false): array
     {
-        $service = 'author-aide';
+        $service = 'authoraide';
         $security = static::getSecurity();
         $secret = static::TEST_CONSUMER_SECRET;
         $request = [

diff --git a/tests/SdkFactoryTest.php b/tests/SdkFactoryTest.php
@@ -44,15 +44,15 @@ public function buildInitDataProvider(): array
                 [
                     'error_message' => 'Argument securityPacket must be set',
                     'arguments' => [
-                        'service' => 'author-aide'
+                        'service' => 'authoraide'
                     ]
                 ]
             ],
             'no secret set' => [
                 [
                     'error_message' => 'Argument secret must be set',
                     'arguments' => [
-                        'service' => 'author-aide',
+                        'service' => 'authoraide',
                         'securityPacket' => [
                             'domain' => 'test'
                         ]
@@ -62,7 +62,7 @@ public function buildInitDataProvider(): array
             'all required parameters set' => [
                 [
                     'arguments' => [
-                        'service' => 'author-aide',
+                        'service' => 'authoraide',
                         'securityPacket' => [
                             'domain' => 'test'
                         ],