Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRN-43664 Remove newer code unavailable in all supported PHP versions #74

Merged
merged 3 commits into from
May 8, 2024

Conversation

david-scarratt-lrn
Copy link
Contributor

Checklist

  • Feature

  • Bug

  • ChangeLog.md updated

  • Tests added

  • All testsuite passes

  • make dist completed successfully

@david-scarratt-lrn david-scarratt-lrn requested a review from shtrom May 6, 2024 11:12
@david-scarratt-lrn david-scarratt-lrn force-pushed the LRN-43664/fix/new-code-old-versions branch from 146a4f9 to 3b64732 Compare May 6, 2024 23:37
Copy link
Contributor

@shtrom shtrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Love the additionalTests

@david-scarratt-lrn david-scarratt-lrn merged commit ad913f9 into master May 8, 2024
1 of 2 checks passed
@david-scarratt-lrn david-scarratt-lrn deleted the LRN-43664/fix/new-code-old-versions branch May 8, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants