Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all training parameters given to the algorithm #83

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

wilrop
Copy link
Collaborator

@wilrop wilrop commented Dec 13, 2023

I have added all training parameters to the config for multi-policy algorithms when logging is turned on. This ensures full transparency of the used parameters when logging results.

As a side note, I think this might also be a useful addition to the single-policy algorithms. However, these algorithms do not yet have a register_additional_config() method in the base class. I was unsure whether you would want this. If yes, let me know and I'll quickly extend this pull request to also log all single-policy parameters.

@wilrop wilrop requested a review from ffelten December 13, 2023 15:46
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-). For the single policies it is a bit trickier because some multi policy algorirthms use the single policies multiple times and this will mess up the wandb config. I'd leave them like this for now

@wilrop
Copy link
Collaborator Author

wilrop commented Dec 13, 2023

That is exactly the reason why I did not yet do it. However, I recommend for the future to find a way to also log those parameters as otherwise people will be left wondering why they got certain results.

@ffelten ffelten merged commit 0907003 into main Dec 13, 2023
2 checks passed
@ffelten ffelten deleted the train-config branch December 13, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants