-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dash prefix for options & Prettier usage #17
Conversation
Thank you, seems better than what I've initially developed (when only crop and delay modes existed). Regarding the
|
Good ideas! How about this for new options?
Of course, Unfortunately, I'm busy with something else for the next two weeks, but after that I would like to work on these things as well as fixing Cut&Merge (unless you want to of course, lol). |
I had to think a bit about that, personally i'm ok in deprecating the backward compatibility mode that specified only the delay parameter, but i'm not so positive in deprecating the whole positional arguments thing because, as far as i know, there are other people using it and don't want to change neither mine nor their workflow, but I'm curious in how would you handle making the output optional, maybe that one can be implemented, i was thinking about looking if the second parameter ends with an extension, if so treat it as output file, otherwise it's an option and must be parsed, what do you think? If you are interested in working in those implementation, i'll be happy to have you take a look at it when you have time, i'm not in a hurry :) |
As it turns out, I did have some time yesterday and already started implementing an optional output file argument for my proposed I went with the easiest solution, which was But I can easily change it back to |
Yeah, i'd prefer, thank you :) For the Also, in my repo there is a kaitai structure file, you can use its webide to explore the structure of the subtitle. |
Since the "modes" act as options on the CLI rather than subcommands (or values), I added the standard "--" prefix to them and added a prettier multiline usage help.
It's backward compatible, the old syntax without the prefixes still works.
I initially thought of adding a
--verbose
/-v
and/or--trace
flag with a different PR to make it easier to analyze the structure of a particular PGS, debug and get feedback of what was changed in the various modes. Hence this idea to first change the others options/flags as well.What do you think?