Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-7908 adding mechanism for TFVAR based secret #132

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

aidenvaines-bjss
Copy link
Contributor

Description

Adds a mechanism by which the authorization headers for the three microservices can be set consistently so that communication between auth, templates and the gateway can be centrally managed per

TF_VAR_amplify_basic_auth_secret is set on the internal repo already, merging this will cause access to be limited while the CDN, IAM-Webauth, and Web-Templates are deployed and pick this up

Context

TDA-2024-03

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@aidenvaines-bjss aidenvaines-bjss requested a review from a team as a code owner December 18, 2024 16:05
mark-r-bjss
mark-r-bjss previously approved these changes Dec 20, 2024
@aidenvaines-bjss aidenvaines-bjss merged commit 73af721 into main Dec 20, 2024
30 checks passed
@aidenvaines-bjss aidenvaines-bjss deleted the CCM-7908_IntraAppBasicAuthCreds branch December 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants