Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM-7711 run acceptance tests in nhs-notify-internal workflow #139

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Ian-Hodges
Copy link
Contributor

@Ian-Hodges Ian-Hodges commented Jan 6, 2025

Description

Change to run acceptance tests in the nhs-notify-internal repository.

Context

For security reasons, we don't want public repositories to hold AWS credentials. This change runs acceptance tests in the new nhs-notify-internal dispatch-acceptance-tests-dynamic-env.yaml workflow. The new nhs-notify-internal workflow will run the acceptance tests in this repository's .github/actions/acceptance-tests folder.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Test evidence

Test evidence has been added to CCM-7711.


Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Ian-Hodges Ian-Hodges force-pushed the feature/CCM-7711_webauth-ci-component-tests branch 2 times, most recently from e3b7a2d to 075df48 Compare January 13, 2025 09:43
@Ian-Hodges Ian-Hodges marked this pull request as ready for review January 13, 2025 14:47
@Ian-Hodges Ian-Hodges requested a review from a team as a code owner January 13, 2025 14:47
@Ian-Hodges Ian-Hodges closed this Jan 13, 2025
@Ian-Hodges Ian-Hodges reopened this Jan 13, 2025
@Ian-Hodges Ian-Hodges closed this Jan 13, 2025
@Ian-Hodges Ian-Hodges reopened this Jan 13, 2025
@Ian-Hodges Ian-Hodges requested a review from a team as a code owner January 13, 2025 18:02
@Ian-Hodges Ian-Hodges requested a review from a team as a code owner January 16, 2025 17:10
@Ian-Hodges Ian-Hodges changed the title CCM-7711 Enable component tests in the ci pipeline CCM-7711 run acceptance tests in nhs-notify-internal workflow Jan 17, 2025
@Ian-Hodges Ian-Hodges reopened this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants