generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCM-7711 run acceptance tests in nhs-notify-internal workflow #139
Open
Ian-Hodges
wants to merge
5
commits into
main
Choose a base branch
from
feature/CCM-7711_webauth-ci-component-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian-Hodges
force-pushed
the
feature/CCM-7711_webauth-ci-component-tests
branch
2 times, most recently
from
January 13, 2025 09:43
e3b7a2d
to
075df48
Compare
Ian-Hodges
changed the title
CCM-7711 Enable component tests in the ci pipeline
CCM-7711 run acceptance tests in nhs-notify-internal workflow
Jan 17, 2025
chris-elliott-nhsd
previously approved these changes
Jan 20, 2025
Ian-Hodges
force-pushed
the
feature/CCM-7711_webauth-ci-component-tests
branch
from
January 21, 2025 10:19
b87292a
to
82cb914
Compare
bhansell1
reviewed
Jan 22, 2025
bhansell1
approved these changes
Jan 22, 2025
harrim91
approved these changes
Jan 23, 2025
gparry333
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change to run acceptance tests in the nhs-notify-internal repository.
Context
For security reasons, we don't want public repositories to hold AWS credentials. This change runs acceptance tests in the new nhs-notify-internal dispatch-acceptance-tests-dynamic-env.yaml workflow. The new nhs-notify-internal workflow will run the acceptance tests in this repository's .github/actions/acceptance-tests folder.
Type of changes
Checklist
Test evidence
Test evidence has been added to CCM-7711.
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.