Skip to content

Commit

Permalink
Fix issue discovered during FluidAPI refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
Amir Roth committed Jan 9, 2025
1 parent 61aaa70 commit 6d57a35
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/EnergyPlus/IceThermalStorage.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1676,9 +1676,8 @@ namespace IceThermalStorage {
//----------------------------
int loopNum = this->plantLoc.loopNum;

// BUG? I think this is supposed to be getSpecificHeat, not getDensity
Real64 CpFluid =
state.dataPlnt->PlantLoop(loopNum).glycol->getDensity(state, state.dataLoopNodes->Node(this->PltInletNodeNum).Temp, RoutineName);
state.dataPlnt->PlantLoop(loopNum).glycol->getSpecificHeat(state, state.dataLoopNodes->Node(this->PltInletNodeNum).Temp, RoutineName);

// Calculate Umyload based on MyLoad from E+
Real64 Umyload = -myLoad * TimeInterval / this->ITSNomCap;
Expand Down

3 comments on commit 6d57a35

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IceStorageFix (Unknown) - x86_64-Linux-Ubuntu-24.04-gcc-13.3: OK (2919 of 2919 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IceStorageFix (Unknown) - x86_64-Linux-Ubuntu-24.04-gcc-13.3-UnitTestsCoverage-RelWithDebInfo: OK (2101 of 2101 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IceStorageFix (Unknown) - x86_64-Linux-Ubuntu-24.04-gcc-13.3-IntegrationCoverage-RelWithDebInfo: OK (801 of 801 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.