Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncdns: fix ncdns.goModules derivation, 2022-10-07 -> 2024-05-18 #331542

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 1, 2024

Description of changes

It took an ungodly amount of time but I may have done it:

  1. Fix the build error in ncdns.goModules due to a module rename in a
    downstream dependency

  2. Add lock files to avoid the same kind of problem that already broke
    the build of ncdns.goModules.
    Note that due to the nature of the x509-compressed module the source
    code dependes on the Go stdlib, so the goModules derivation
    is still not really fully reproducible, but it comes closer.

  3. Make ncdns behave more like a normal Go module and use the built-in
    phases of goBuildModule.

  4. Bonus update

Fixes #331188

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested via ncdns.tests
  • Tested compilation of all packages that depend on this change
  • Tested basic functionality of all binary files
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

rnhmjoj added 2 commits August 1, 2024 15:57
It took an ungodly amount of time but I may have done it:

1. Fix the build error in ncdns.goModules due to a module rename in a
   downstream dependency

2. Add lock files to avoid the same kind of problem that already broke
   the build of ncdns.goModules.
   Note that due to the nature of the x509-compressed module the source
   code dependes on the Go stdlib, so the goModules derivation
   is still not really fully reproducible, but it comes closer.

3. Make ncdns behave more like a normal Go module and use the built-in
   phases of goBuildModule.
@rnhmjoj rnhmjoj merged commit 80b9606 into NixOS:master Aug 1, 2024
30 of 32 checks passed
@rnhmjoj rnhmjoj deleted the pr-ncdns branch November 29, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: ncdns
1 participant