48 adding fmcw nodes to existing develop branch being required #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 13, 2024 17:18
Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de>
…apping nodes not regarded yet, redundancy of nodes possible for now). Also tags are added for each FMCW-Node. Signed-off-by: TimoHinsemann <timo.hinsemann@persival.de>
TimoHinsemann
requested review from
PhRosenberger,
ClemensLinnhoff and
ChristophPopp
ClemensLinnhoff
requested changes
Jan 7, 2025
src
Outdated
There was a problem hiding this comment.
This does not point to a commit on the main branch. The source repo need to be updated first, so lidar-limbs is not pointing to a feature branch which might not exist anymore in the future.
There was a problem hiding this comment.
Okay makes sense, so we should maybe talk soon about the repo-changes and if they are acceptable for the main-branch
There was a problem hiding this comment.
Please create a pull request in https://github.com/PerCollECT/Source-Files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36 , #42 , #45 and #48.
Changes are already discussed with @ChristophPopp - Merging to develop-branch seems right for now. (?)