Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add User-Agent #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add User-Agent #5

wants to merge 5 commits into from

Conversation

Aram47
Copy link
Contributor

@Aram47 Aram47 commented Dec 18, 2024

No description provided.

@Aram47 Aram47 closed this Dec 23, 2024
@Aram47 Aram47 reopened this Dec 23, 2024
README.md Outdated
@@ -14,15 +19,15 @@ A Command Line Interface (CLI) tool for removing backgrounds and upscaling image
1. **Clone this repository**:
```bash
git clone https://github.com/eax-academy/cli-plugin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
@@ -14,15 +19,15 @@ A Command Line Interface (CLI) tool for removing backgrounds and upscaling image
1. **Clone this repository**:
```bash
git clone https://github.com/eax-academy/cli-plugin
cd image-processor-cli
cd picsart-cli
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do only 'picsart' and not 'picsart-cli'? what needs to change for this? pls adapt

@@ -3,7 +3,7 @@ version: '1.0.0'

helpOption:
flags: '-h, --help'
description: 'Display help for the image-processor CLI tool'
description: 'Display help for the picsart CLI tool'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the brand name Picsart with upper case P and lower case a: Picsart
this is very important, please check the whole readme and adapt as needed

package.json Outdated
@@ -10,7 +10,7 @@
"author": "",
"license": "ISC",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this our lib's license?
it should be MIT then .... please check and fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants