Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace, filename and property-name cleanups #55

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

reisenberger
Copy link
Member

  • Clean up namespaces for Options classes
  • Rename some internal properties XInternal, to avoid clashes with identically named methods. (If identically named, the compiler resolves the correct item (the method) when the correct using statement is in place; but gives messages about 'Cannot access internal property', which may be confusing for users, if the using statement is missing.)
  • Rename some *Fault* files/classes to *Outcome*

@reisenberger reisenberger added this to the V0.3.0 milestone Dec 3, 2019
@reisenberger
Copy link
Member Author

@vany0114 This is the PR you can merge onto yours if you are happy.


It's frustrating that the build sometimes fails the second build of a PR because of

Build with specified version already exists

we can try to have a look at that ...

@reisenberger reisenberger mentioned this pull request Dec 3, 2019
@vany0114
Copy link
Member

vany0114 commented Dec 3, 2019

Thanks a lot @reisenberger!

It's frustrating that the build sometimes fails the second build of a PR because of [...]

Yeah, it's very annoying, I can create an issue if you want, just to have it on the radar.

@reisenberger
Copy link
Member Author

It's frustrating that the build sometimes fails the second build of a PR because of [...]

Yeah, it's very annoying, I can create an issue if you want, just to have it on the radar.

Opened #56 with some investigation.

@vany0114 vany0114 merged commit 8dcf3d5 into vany0114-new-syntax Dec 3, 2019
@vany0114 vany0114 deleted the reisenberger-optionsSyntaxNamespace branch January 4, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants