Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add kube-qps and kube-burst parameters. #769

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Jan 2, 2025

What type of PR is this?

/kind feature
What this PR does / why we need it:
dd kube-qps and kube-burst parameters
Which issue(s) this PR fixes:
Fixes #745

Special notes for your reviewer:

Depends on PR #681

Does this PR introduce a user-facing change?:

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 45.16129% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/util/client/client.go 46.66% 13 Missing and 3 partials ⚠️
pkg/scheduler/scheduler.go 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 44.42% <45.16%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/scheduler.go 35.08% <0.00%> (+0.47%) ⬆️
pkg/util/client/client.go 42.22% <46.66%> (-11.95%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scheduler: client-side throttling, not priority and fairness
1 participant