-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat #470: Remove Qbeast Provider from the Catalog #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosepSampe
approved these changes
Jan 20, 2025
Closing it due to inactivity. Would be reopened when we have time to dedicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solution for Qbeast-io/qbeast-spark-private#4. Instead of using the "qbeast" alias in the provider, we will switch to the underlying table format selected. This PR is a proposal and I prefer to review the conceptual feature before proceeding with the opening of the PR.
Type of change
New feature.
The internal components change include:
columnsToIndex
,cubeSize
, columnStats orqbeast.revision
...tableFormat
. This represents the underlying Provider in which the Table would be saved and represented to the users.tableFormat
is to one of the supported formats. Otherwise, it would throw an error.Checklist:
Here is the list of things you should do before submitting this pull request:
How Has This Been Tested? (Optional)
The tests are split within: