Added support of sessions by requests, removed dependency of urllib's authentications #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholascar
approved these changes
Jan 15, 2024
|
Thanks @Huddeij for this PR. It has been long overdue to add sessions. I'll just run a couple of local tests and then merge this creating a new version of SPARQLWrapper. |
|
Hi @nicholascar any update on this? Edit: tried this patch in combination with apache jena fuseki, and it was giving me this error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the need of more than the 2 standard HEADER-based authentications (BASIC, DIGEST) there is a need of a session based solution.
Now the library uses the library requests with that the user prepares an authenticated session and hands it over to the library before the sparql query is send to the server. This way the urllib library was deprecated. As long as a valid session is forwarded, the query is valid.
It still supports the legacy way, but all urllib based methods are marked as deprecated.
Further changes to the codebase were made to go a bit with pythons evolution, like the implementataion of f-strings for example.