Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JJ-17] Showcase user statistics #57

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Conversation

RamziJabali
Copy link
Owner

@RamziJabali RamziJabali commented Jun 4, 2024

PR Description

This PR was deigned to be able to showcase user jog information within the statistics view.

Changes Made

Describe the changes that were made in this PR. Be as detailed as possible to help the reviewers understand what was done.

  • Created Retrofit dependency injections
  • Created Quotable API Dependency Injection
  • Created Statistics ViewModel
  • Handling permissions was added, using pop up dialog boxes
  • Moved FAB from scaffold to Statistics View
  • Statistics View now shows up to date user information regarding jogs
  • Statistics View shows motivation quote

Fixes Made

  • Bug when handling permissions when wanting to show permission pop up dialog. Causes permission dialog to not show up appropriately.
    • Caused by logic being split in both viewmodel and mainactivity.
    • Resolved by moving all logic to viewmodel and all required methods from main activity were hoisted into the view.
  • Bug when user finishes jog. User does not get updated jog information.
    • Caused by Stop intent not opening main activity causing the user to see out dated information
    • Resolved by adding pending intent to open mainactivity when jog is stopped.

Bugs Found

If any new bugs were discovered during the development of this PR, please list them here along with any relevant details.

Show case:

Screen_recording_20240625_135313.mp4

…t DI, Created Statistics viewmodel, finished Statistics view
@RamziJabali RamziJabali self-assigned this Jun 4, 2024
@RamziJabali RamziJabali linked an issue Jun 4, 2024 that may be closed by this pull request
@RamziJabali RamziJabali changed the title [JJ-17] Make Statistics Page Alive [JJ-17] Showcase user statistics Jun 4, 2024
@RamziJabali RamziJabali marked this pull request as ready for review June 25, 2024 20:45
@RamziJabali RamziJabali merged commit ecc34de into main Jun 25, 2024
1 check passed
@RamziJabali RamziJabali deleted the JJ-17-Show-Case-Statistics branch June 25, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JJ-17] Showcase user jog in statistics page
1 participant