This repository has been archived by the owner on Feb 12, 2020. It is now read-only.
code reviewed #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Service class Added Person class Added search functionality Updated .gitignore Added tests for failures Added functionality to handle failures
Created functions to store a new person into the database Refactored test and functions
Created MongoDB object to handle database transactions Created DummyDatabase object to handle database test transactions Refactored tests for reusablity Deleted IDE specific files
Refactored functions to work with tokens Created test for requesting a client token Created functions for creating a client token Created user interface for requesting a client token
Created functions for updating a person Upgraded Play! framework version to 2.2.1
Refactored code for generic error handeling/throwing Refactored functions to minimise duplicated code
Added functionality to retrieve a person by id Added test for search for a non existing id Refactored functionality to handle non existing id
…on of location and time
…ult radius is 10km
Added BadRequest handler Removed most Option wrappers Modified tests so database no longer needs to be emptied
…ail and password combination Removed unused files Restructured application
Added test to verify encrypting Added functions for encrypting
Added functionality for changing password Added user interface for changing password
Fixed a problem in the API (server problems did not translate into JSON) Fixed a problem where updating a person with extra data would lose the extra data Changed retrieving a token from a POST to a GET request Changed changing password so that it will check if the user inputted a existing email Changed tests to be independant of MongoDB Added in memory database classes for testing Added specific test specification for MongoDB Changed global to allow for test databases being used Added language independant messages Restructered packages and class names to be more meaningful Added functionality for mailing reset URL to user Added tests for handeling exceptions Changed current functions to handle exceptions Refactored the tests to be faster Fixed issues raised by new failing tests Seperated encryption methods into encryption class Refactored Mongo database based classes to use reactive mongo Refactored to put duplicated code in seperated classes for re-usability Removed unused imports Divided Portal in to two parts - One handeling all input requests (Responds in Json) - One handeling all user input (Responds in html) Refactored Global - Accepts an encryption - No longer requires database name (now reads from config) Refactored tests - Altered tests to reuse existing code Fixed test that would occasionaly fail
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.