Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: supports phpunit10 #106

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: supports phpunit10 #106

merged 1 commit into from
Feb 13, 2024

Conversation

Goodmain
Copy link
Contributor

@Goodmain Goodmain commented Feb 8, 2024 •
edited
Loading

At the PHPUnit 10 they have changed InvocationOrder->getInvocationCount() to InvocationOrder->numberOfInvocations(). So to support both versions I added checking of the getInvocationCount function.

Also there was an issue with $startedTestSuite at the TestCase.

@Goodmain Goodmain requested a review from DenTray February 8, 2024 20:08
DenTray
DenTray requested changes Feb 13, 2024
View reviewed changes
src/Traits/MockTrait.php Show resolved Hide resolved
@DenTray DenTray merged commit b0e2b10 into master Feb 13, 2024
2 checks passed
@Goodmain Goodmain mentioned this pull request Mar 7, 2024
Closed
@Goodmain Goodmain deleted the support-php-unit10 branch June 21, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenTray DenTray DenTray approved these changes

Assignees

@Goodmain Goodmain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goodmain @DenTray