Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(php-buildpack): revamp extensions page #2961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Frzk
Copy link
Contributor

@Frzk Frzk commented Jan 14, 2025

  • List native, PECL and proprietary extensions available.
  • For PECL and proprietary ones, also list versions.
  • Add instructions to enable and add extensions.

@Frzk Frzk self-assigned this Jan 14, 2025
@Frzk Frzk marked this pull request as ready for review January 14, 2025 18:30
@Frzk Frzk requested a review from leo-scalingo January 14, 2025 18:30
All [PECL extensions](https://pecl.php.net/) are available. If the extension
you need is not in the above list of pre-installed extensions, it will be
compiled during the *build* phase of your deployment.
### Available PECL Extensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that all PECL extensions are available, aren't they? This is my understanding of the code here:

https://github.com/Scalingo/php-buildpack/blob/04665141895505dd51aadf83beba9c2f1c49c9f2/lib/pecl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right, it's either we have them pre-built or or we try to compile them on the fly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EtienneM: What @leo-scalingo wrote :)

The ones I listed are the one we pre-compile (maybe it's worth mentioning this for a better understanding). For all others, we try to compile them on the fly, which works in most cases.

BUT sometimes it requires more work (because dependencies, etc.).

And sometimes it doesn't work.

  • For example I tried to install the datadog_trace PECL extension yesterday and couldn't manage to do it :(
  • Another example is the scoutapm PECL extension, which is in fact a Zend extension and requires to be enabled with specific instructions (we handle it for the users)

Consequently, writing that "we support all PECL extensions" is a bit too much IMHO. That's why I decided to remove this sentence. I'll add precisions though, you're right.

I'll also try to steal a bit of @leo-scalingo's time someday to talk about all this (related to Scalingo/php-buildpack#363)

Copy link
Contributor

@leo-scalingo leo-scalingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So great, thanks @Frzk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants