Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Update qtox windows builder image to Qt 6.8.1. #212

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 26, 2024

We don't need to download the entire Qt source code. We only use 3 modules: qtbase, qttools, qtsvg. Also, parallelised the 3 main sections of the image build: Qt, non-Qt deps, and gdb.

Also, upgraded the Windows Qt version to 6.8.1. This is possible because of our host-qt image, which has the latest Qt built for Linux.


This change is Reviewable

@iphydf iphydf added this to the master milestone Dec 26, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Dec 26, 2024
@iphydf iphydf force-pushed the windows-qt branch 2 times, most recently from f7ffb03 to e2d047f Compare December 26, 2024 01:43
@iphydf iphydf requested a review from a team as a code owner December 26, 2024 01:43
qtox/build_qt_windows.sh Show resolved Hide resolved
qtox/build_qt_windows.sh Show resolved Hide resolved
We don't need to download the entire Qt source code. We only use 3
modules: qtbase, qttools, qtsvg. Also, parallelised the 3 main sections
of the image build: Qt, non-Qt deps, and gdb.

Also, upgraded the Windows Qt version to 6.8.1. This is possible because
of our host-qt image, which has the latest Qt built for Linux.
@iphydf iphydf changed the title cleanup: Speed up qtox windows builder image build. cleanup: Update qtox windows builder image to Qt 6.8.1. Dec 26, 2024
@toktok-releaser toktok-releaser merged commit c2eeca9 into TokTok:master Dec 26, 2024
41 checks passed
@iphydf iphydf deleted the windows-qt branch December 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

4 participants