Test Opendap and WMS are applying enhancements correctly #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdrwenski
changed the title
tdrwenski
force-pushed
the
ncml-enhancements
branch
3 times, most recently
from
3cd53e8 to
d359b4c
Compare
added 5 commits
January 11, 2024 10:19
tdrwenski
force-pushed
the
ncml-enhancements
branch
from
d359b4c to
2e00cb6
Compare
tdrwenski
changed the title
haileyajohnson
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure both the case of variable enhancement attributes (such as add_offset) in a file and in NcML are tested for NCSS, Opendap, and WMS:
TestEnhancementsTestEnhancementsin this PR. Also added NcMLenhance=nonecase.TestWmsServer, NcML enhancement test added in this PRFor the situation tested, NCSS and WMS apply enhancements for both inherent attributes and NcML. Opendap applies the enhancements for NcML when
enhance=allis specified but not ifenhance=noneis specified. Opendap does not apply inherent enhancements to data (so it provides packed binary data).This change is