Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for remote GDB via intermediate remote server #192 #222

Closed

Conversation

mohamedchebbii
Copy link

@mohamedchebbii mohamedchebbii commented May 8, 2020

This is my first Node.js code ever, so please bear with me.
I did not manage to add test case for this code

I added the following conf:

        "ssh":
        {
            "host": "${env:REMOTE_SERVER})",
            "cwd": "binary_name", 
            "keyfile": "${env:HOME}/.ssh/id_rsa",
            "user": "${env:USERNAME}",
            "password": "${env:PASSWORD}"
        },
        "proxyConnection":
        {
            "host": "${env:PROXY_SERVER}",
            "username": "${env:PROXY_USER}",
            "identity": "${env:HOME}/.ssh/id_rsa" 
        }`

Copy link
Owner

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this needs ssh2-promise, ssh2 supports proxies too.

There are also a lot of unrelated formatting changes which you should remove first in mi2.ts starting on line 140

The change seems overly large in mi2.ts for just exposing the proxy setting of ssh2, having a secondary ssh2-promise implementation for the same goal is not a good idea here. You should remove ssh2-promise or convert the existing code to ssh2-promise first (not an alternative branch) and make these changes in a separate PR.

@mohamedchebbii
Copy link
Author

please ignore this PR asd check #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants