Change time functions #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ros_Duration_Msg_To_Milliswas previously broken because the calculation would have a 32 bit result that would overflow before being cast. We just never ran into that problem because most durations are relatively short and there is no real chance of overflow unless a duration is at least several weeks long (which is obviously unlikely). I only realized that it was broken because I was trying to writeRos_Time_Msg_To_Millisby copying the contents ofRos_Duration_Msg_To_Millisand it was overflowing there.I added more of the time message functions, because it will be useful for issues that may be completed in the future, (#29, #51, possibly others).