Return unpackTx's type in sendTransaction #1762
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `confirmationHeight` is not returned in `sendTransaction` Use `getHeight` to get current height.
BREAKING CHANGE: tx builder doesn't support `denomination` option Convert AE amounts to aettos manually or use `formatAmount` helper function.
BREAKING CHANGE: `getBalance` return bigint and not accepting `format` Use `formatAmount` to format manually. Call `.toString()` on return value if necessary.
BREAKING CHANGE: Channel:balances returns bigints instead of strings Call `.toString()` on return returned balance if necessary.
BREAKING CHANGE: `transferFunds` not accepts string anymore Implement a custom algorithm if you need accuracy more than provided by number type.
BREAKING CHANGE: `buildContractId`, `oracleQueryId` accepting nonce only as a number
Codecov ReportBase: 82.72% // Head: 82.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1762 +/- ##
===========================================
- Coverage 82.72% 82.68% -0.05%
===========================================
Files 90 90
Lines 3086 3073 -13
Branches 615 611 -4
===========================================
- Hits 2553 2541 -12
+ Misses 247 245 -2
- Partials 286 287 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidyuk
force-pushed
the
develop
branch
3 times, most recently
from
1948f5f to
68edc25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supported by the Æternity Crypto Foundation