Fix verdi devel check-undesired-imports when tui extra is installed

[danielhollas]

Fixes #6691.

To test the fix run

uv sync --extra tui
uv run verdi devel check-undesired-imports

This will fail on main with

Warning: Detected loaded module "asyncio"
Critical: Detected 1 unwanted modules

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.05%. Comparing base (aa0aa26) to head (3e83606).

Files with missing lines	Patch %	Lines
src/aiida/cmdline/commands/cmd_devel.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6693      +/-   ##
==========================================
- Coverage   78.05%   78.05%   -0.00%     
==========================================
  Files         563      563              
  Lines       41790    41793       +3     
==========================================
  Hits        32616    32616              
- Misses       9174     9177       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agoscinski]

Should we include the extras here again? We just removed the extras because of the tui problem right?

[danielhollas]

No, the extras were never included in this check, and I don't see why we should include them if they are not needed here.

[agoscinski]

They caught the error that this PR is fixing or am I wrong?

[agoscinski]

In the end I just would like to test it with all extras. We could also make a dedicated tests that adds all dummy modules under the name of the extras into the sys but that would not consider dependencies. I am not sure if there is a smart way to test the fix here without installing all extras.

[danielhollas]

They caught the error that this PR is fixing or am I wrong?

I wouldn't really call this an error, it is just fixing a test essentially. (note that even though it's part of verdi devel it's not really meant to be used by users)

I dunno, you're basically asking to test the test. I could argue in the opposite direction -- basically all the CI jobs are installing the extras so it's good to have this one thing without the extras.

Anyway, feel free to push to this branch and merge, I will not have time to get to this this week.

[agoscinski]

I wouldn't really call this an error, it is just fixing a test essentially. (note that even though it's part of verdi devel it's not really meant to be used by users)

ok fair enough

[agoscinski]

thanks for the fix! had just one question

[agoscinski]

Thanks for the work!

[danielhollas]

@agoscinski thanks for the review!

(btw: just in case you're not aware I don't have permissions to merge things on this repo so somebody else needs to push the button :-) )