Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] logger error: joind need str not int or bool #27

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

njeudy
Copy link

@njeudy njeudy commented Jan 2, 2025

@alexis-via here is my small contrib to your module :)

@njeudy njeudy changed the base branch from 18.0 to 16.0 January 2, 2025 13:10
@@ -930,7 +930,7 @@ def reconcile_move_lines(self, moves):
logger.warning(
"Skip reconcile of ref '%s' because the lines with "
"this ref have different partners (IDs %s)",
rec_ref, ', '.join(partners.keys()))
rec_ref, ', '.join([str(x) for x in partners.keys() if x not in [False, None]]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @njeudy , I'm not sure but what do you think ?

Suggested change
rec_ref, ', '.join([str(x) for x in partners.keys() if x not in [False, None]]))
rec_ref, ', '.join([str(x) for x in partners.keys() if x]))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants