Postgres fix + English localization #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your work and I will complete the merger as soon as possible |
|
@amisadmin any update on this? |
|
Hello, this commit has not been merged, mainly because some of the changes are for Postgres, but at present I use mysql here and sqllite in the test environment, and I hope to find an implementation that is perfectly compatible with these three. |
|
@MatsiukMykola hi, can you split this into two PRs? One for English i18n and another for Postgres fix. I think everybody would be OK for the i18n change at least. |
under air alarm every day this can be a little "difficult" |
Murl1k
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Postgres compatibility (SQLite does not work now, this is in progress).
, so there can be typos) and prepared to use with i18n (in progress).
Translated to English strings (my native - Ukraine language
Work in progress. PR - you are welcome!