Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of gas error message #4269

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix out of gas error message #4269

wants to merge 5 commits into from

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Jan 23, 2025

Describe your changes

Closes #4250.

Fixes the tx out of gas error message that was previously displaying sub-units of gas. To do so I've modified the gas meters to cache the gas limit protocol parameter to have it readily available at all times (and avoid redundant accesses to the storage).

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

grarco added a commit that referenced this pull request Jan 23, 2025
@grarco grarco marked this pull request as ready for review January 23, 2025 15:07
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 98.76543% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.04%. Comparing base (0f54f09) to head (31d8fd4).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/dry_run_tx.rs 33.33% 2 Missing ⚠️
crates/node/src/shell/finalize_block.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4269   +/-   ##
=======================================
  Coverage   74.03%   74.04%           
=======================================
  Files         345      345           
  Lines      109920   110010   +90     
=======================================
+ Hits        81377    81453   +76     
- Misses      28543    28557   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buggy error message: Out of gas: Transaction gas limit exceeded maximum of 2500000000
2 participants