Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support enable_url_table config #980

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

chenkovsky
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

without url table support, we have to create table, if we want to query a file.

What changes are included in this PR?

support enable_url_table config

Are there any user-facing changes?

No

@timsaucer
Copy link
Contributor

timsaucer commented Jan 7, 2025

Thank you for the addition! Would it be simpler to just expose the function on the session context instead of making it part of the initialization? Even if you do think it's important to have it in initialization, we probably should expose the function also to maintain parity with the rust version.

@chenkovsky
Copy link
Contributor Author

Thank you for the addition! Would it be simpler to just expose the function on the session context instead of making it part of the initialization? Even if you do think it's important to have it in initialization, we probably should expose the function also to maintain parity with the rust version.

updated

@timsaucer
Copy link
Contributor

Very nice. Thank you. I've kicked off CI and will merge if all goes through.

@timsaucer timsaucer merged commit 389164a into apache:main Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants