-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5277] improvement(cli): display index information for tables in the Gravitino CLI #5476
[#5277] improvement(cli): display index information for tables in the Gravitino CLI #5476
Conversation
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Outdated
Show resolved
Hide resolved
Thanks for the PR. For it to be consistent with other commands, I would output in CSV format with an index (and its type) on each line. |
4cc789c
to
30567dd
Compare
30567dd
to
415b62e
Compare
415b62e
to
da09889
Compare
26ad68d
to
7c47bc3
Compare
7c47bc3
to
096623b
Compare
4d87f93
to
1ee1138
Compare
This is also done! |
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListIndexes.java
Outdated
Show resolved
Hide resolved
My question from another PR (#5525 (comment)), why do we need a new option to display the index information, can we just display all the table metadata information in one |
247ac5b
to
4ad6d99
Compare
See #5525 (comment) |
@jerryshao can we move forward on this? |
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Outdated
Show resolved
Hide resolved
I've left the comment in another PR, I'm +0 on the current design choice, but I don't want to block things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution
@jerryshao can you approve this? I approved this but I can't merge it. |
What changes were proposed in this pull request?
Add
--index
option to display index information onTables
.Fix
TableDetails
command.Update
cli/README.md
for table commandsWhy are the changes needed?
This change allows users to retrieve additional index information on
Tables
, providing more insights.Fix: #5277
Does this PR introduce any user-facing change?
Yes, it adds the
--index
option toCommandEntities.TABLE
.How was this patch tested?
To test, use a command like the following:
Check that the output matches the expected audit information.