Fix build with clang 16 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 16 (and likely GCC 13) enables -Wimplicit-function-declaration by
default. This results in errors such as:
signify.c:144:6: error: call to undeclared function 'b64_pton'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (b64_pton(commentend + 1, buf, buflen) != buflen)
^
signify.c:231:6: error: call to undeclared function 'b64_ntop'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (b64_ntop(buf, buflen, b64, sizeof(b64)) == -1)
^
signify.c:624:12: error: call to undeclared function 'b64_pton'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if ((rv = b64_pton(hash, data, sizeof(data))) == -1)
A simple fix is to create a base64.h file containing the headers of the
b64_* functions.
Bug: https://bugs.gentoo.org/894354
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
listout
added a commit
to listout/gentoo
that referenced
this pull request
Jul 29, 2023
Upstream PR: aperezdc/signify#43 Closes: https://bugs.gentoo.org/894354 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 30, 2023
Upstream PR: aperezdc/signify#43 Closes: https://bugs.gentoo.org/894354 Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com> Closes: #32097 Signed-off-by: Michał Górny <mgorny@gentoo.org>
aperezdc
requested changes
Mar 6, 2024
| @@ -34,6 +34,7 @@ | |||
| #include "sha2.h" | |||
|
|
|||
| #include "crypto_api.h" | |||
| #include "base64.h" | |||
There was a problem hiding this comment.
Instead of adding a new header, wouldn't it be enough to add the function prototypes to compat.h?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 16 (and likely GCC 13) enables -Wimplicit-function-declaration by default. This results in errors such as:
signify.c:144:6: error: call to undeclared function 'b64_pton'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (b64_pton(commentend + 1, buf, buflen) != buflen)
^
signify.c:231:6: error: call to undeclared function 'b64_ntop'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if (b64_ntop(buf, buflen, b64, sizeof(b64)) == -1)
^
signify.c:624:12: error: call to undeclared function 'b64_pton'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
if ((rv = b64_pton(hash, data, sizeof(data))) == -1)
A simple fix is to create a base64.h file containing the headers of the b64_* functions.
Bug: https://bugs.gentoo.org/894354