Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Commit

Permalink
Upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
Gregoirevda committed May 21, 2018
1 parent c2c45e6 commit 524a1e9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ Features:
Fixes:
- Mutation result pattern matching

v 0.9.0

This comment has been minimized.

Copy link
@emmenko

emmenko May 23, 2018

Contributor

Sorry to be picky, but a breaking change would mean a major bump 1.0.0. Can we do that? 🙏

This comment has been minimized.

Copy link
@Gregoirevda

Gregoirevda May 23, 2018

Author Contributor

We would be at version 100 by the end of the year. Only when the whole package is binded and stable, I'll go to 1.0.0 and then apply strict semver

This comment has been minimized.

Copy link
@emmenko

emmenko May 23, 2018

Contributor

Well, at the end the version doesn't really matter (even if it's 100 at the end of the year 😄).
I understand your point but I also think we should follow semver as much as possible.

Alternative: we mark it as e.g. RC, or beta-xxx until we "consider" it stable.

WDYT?

This comment has been minimized.

Copy link
@Gregoirevda

Gregoirevda May 23, 2018

Author Contributor

I'm sorry emmenko, but I'll keep it this way. Even if I realise it's not a perfect solution, the strict semver from day 1 isn't neither

This comment has been minimized.

Copy link
@emmenko

emmenko May 23, 2018

Contributor

Sure, no hard feelings from my side 😇 At least we clarified this point!

Breaking changes:
- Mutation: added `NotCalled` tag to result variant
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "reason-apollo",
"version": "0.8.0",
"version": "0.9.0",
"license": "MIT",
"sideEffects": "false",
"description": "Using Apollo client 2 with Reason",
Expand Down

0 comments on commit 524a1e9

Please sign in to comment.