Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zksyncSepolia token deposits and treasury #1365

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Jun 6, 2024

Description

Adjusts chain metadata config for 'ethereum' as mainnet pair in conjunction with backend updates to grab tokens with correct prices and logos. zkSync is not supported yet as mainnet and sepolia testnet doesn't contain proper metadata for native token.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @thekidnamedkd!

@cgero-eth cgero-eth merged commit abbd27f into develop Jun 7, 2024
3 checks passed
@cgero-eth cgero-eth deleted the feat/fix-zksync-deposit-eth branch June 7, 2024 07:53
Copy link

github-actions bot commented Jun 7, 2024

WebApp IPFS Hash: QmVypcbz4ycoJhwZcUQUuzxzv3LhW4Mr5qKQmEmkqq9ffD
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmVypcbz4ycoJhwZcUQUuzxzv3LhW4Mr5qKQmEmkqq9ffD/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants