Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3406): Removed multisig members are still displayed at member page and included in member count #1388

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Jul 16, 2024

Description

Compare before and after:

Member Page Before (see here)
image

Member Page After
image

Settings Page Before
image

Settings Page After
image

Task: APP-3406

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@Barukimang Barukimang requested a review from cgero-eth July 16, 2024 11:43
@cgero-eth cgero-eth changed the title fix: APP-3406 - Multisig - Removed members are still displayed at member page and included in member count fix(APP-3406): Removed multisig members are still displayed at member page and included in member count Jul 16, 2024
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Barukimang!

@cgero-eth cgero-eth merged commit 8c0eea5 into develop Jul 16, 2024
2 checks passed
@cgero-eth cgero-eth deleted the fix/app-3406-removed-members-displayed-2 branch July 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants