Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-2916): Proposal creation requirements are not in the correct part of the DAO creation flow #1395

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Aug 2, 2024

Description

Compare before and after below. Created this DAO with 'Any wallet' proposal setting. It works and did not find other adverse effects.

Before
image

After
image

Task: APP-2916

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title fix: APP-2916 - Proposal creation requirements are not in the correct part of the DAO creation flow fix(APP-2916): Proposal creation requirements are not in the correct part of the DAO creation flow Aug 8, 2024
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Barukimang!

@cgero-eth cgero-eth merged commit aa2187a into develop Aug 8, 2024
2 checks passed
@cgero-eth cgero-eth deleted the fix/app-2916-multisig-prop-req branch August 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants